Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PodioExample #352

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Refactor PodioExample #352

merged 10 commits into from
Sep 5, 2024

Conversation

nathanwbrei
Copy link
Collaborator

  • Split into reusable PodioDatamodel, PodioFileReader, PodioFileWriter
  • Remove Podio-related abstractions from libJANA that never quite worked

We stop using DatamodelGlue.h everywhere while we are at it. This is because the DatamodelGlue concept noticeably slows down compilation when the data model gets large. We still need a datamodel visitor for event sources, but shouldn't need it anywhere else.
This gets us out of the mess where user classes are required to have certain constructor arguments in order to forward them to the parent constructor.
This was a bad abstraction. The use of the templated visitor pattern obscured some very simple code. It is far better for users to copy-paste PodioFileReader and adapt for their needs.
This isn't a reusable abstraction or utility either.
@nathanwbrei nathanwbrei marked this pull request as ready for review September 5, 2024 15:49
@nathanwbrei nathanwbrei merged commit c07aad2 into master Sep 5, 2024
9 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_podio_example_refactoring branch September 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant